fix test ci #3832
Merged
fix test ci #3832
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johrstrom
commented
Sep 27, 2024
Comment on lines
-513
to
+517
| `touch #{dir_to_dl}/real_file` | ||
| `touch #{dir_to_dl}/first_level_dir/.second_level_hidden_file` | ||
| `touch #{dir_to_dl}/first_level_dir/second_level_real_file` | ||
| `touch #{dir_to_dl}/.first_level_hidden_dir/.another_second_level_hidden_file` | ||
| `touch #{dir_to_dl}/.first_level_hidden_dir/another_second_level_real_file` | ||
| `echo 'abc123' > #{dir_to_dl}/real_file` | ||
| `echo 'abc123' > #{dir_to_dl}/first_level_dir/.second_level_hidden_file` | ||
| `echo 'abc123' > #{dir_to_dl}/first_level_dir/second_level_real_file` | ||
| `echo 'abc123' > #{dir_to_dl}/.first_level_hidden_dir/.another_second_level_hidden_file` | ||
| `echo 'abc123' > #{dir_to_dl}/.first_level_hidden_dir/another_second_level_real_file` |
There was a problem hiding this comment.
It's not clear to me why I had to change this. This test was failing saying that the directories were empty.
Seems like we used to be able to download empty directories and that's somehow changed? I'd say this needs looking into.
There was a problem hiding this comment.
This is an operating system/du change! I'll open another ticket.
ashton22305
approved these changes
Sep 30, 2024
johrstrom
added a commit
that referenced
this pull request
Oct 7, 2024
Fix test ci by populating these test files so that the directory isn't empty.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix test ci because apparently
libsqlite3-devisn't on these images anymore?